Change in coreboot[master]: cbfstool: Do host space address conversion earlier when adding files

[Raul Rangel (Code Review)]

Attention is currently required from: Patrick Georgi, Tim Wawrzynczak, Julius Werner.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60018 )

Change subject: cbfstool: Do host space address conversion earlier when adding files
......................................................................

Patch Set 3: Code-Review+2

(3 comments)

File util/cbfstool/cbfstool.c:

https://review.coreboot.org/c/coreboot/+/60018/comment/b6783895_eaba3329 
PS2, Line 1078: offset
> Fixed, thank you!

I commented on this part in your previous CL because I misread the intention. Guessing that's what sparked this CL.

File util/cbfstool/cbfstool.c:

https://review.coreboot.org/c/coreboot/+/60018/comment/03e7ce7b_a8009ccc 
PS3, Line 813: offset
If I'm reading this right, this assumes a flash_offset is always passed in right? I don't see anything validating this assumption.

https://review.coreboot.org/c/coreboot/+/60018/comment/23f6c724_722b7a98 
PS3, Line 1052: offset
One thing you could do to make this easier to read is rename `offset` to `flash_offset`, and `address` to `host_address`. That way there is no confusing the two values.