Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36773 )
Change subject: nb/intel/i440bx: Remove unnecessary __SIMPLE_DEVICE__ ......................................................................
nb/intel/i440bx: Remove unnecessary __SIMPLE_DEVICE__
This file is only included in romstage.
Change-Id: Ib9ee6e88e7a6ef81034de608232a05e92a16d5f4 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/i440bx/memmap.c 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/36773/1
diff --git a/src/northbridge/intel/i440bx/memmap.c b/src/northbridge/intel/i440bx/memmap.c index d260af6..5c47ed0 100644 --- a/src/northbridge/intel/i440bx/memmap.c +++ b/src/northbridge/intel/i440bx/memmap.c @@ -13,8 +13,6 @@ * GNU General Public License for more details. */
-#define __SIMPLE_DEVICE__ - #include <arch/romstage.h> #include <device/pci_ops.h> #include <cbmem.h>
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36773 )
Change subject: nb/intel/i440bx: Remove unnecessary __SIMPLE_DEVICE__ ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36773 )
Change subject: nb/intel/i440bx: Remove unnecessary __SIMPLE_DEVICE__ ......................................................................
nb/intel/i440bx: Remove unnecessary __SIMPLE_DEVICE__
This file is only included in romstage.
Change-Id: Ib9ee6e88e7a6ef81034de608232a05e92a16d5f4 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36773 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/northbridge/intel/i440bx/memmap.c 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/northbridge/intel/i440bx/memmap.c b/src/northbridge/intel/i440bx/memmap.c index d260af6..5c47ed0 100644 --- a/src/northbridge/intel/i440bx/memmap.c +++ b/src/northbridge/intel/i440bx/memmap.c @@ -13,8 +13,6 @@ * GNU General Public License for more details. */
-#define __SIMPLE_DEVICE__ - #include <arch/romstage.h> #include <device/pci_ops.h> #include <cbmem.h>
-
Arthur Heymans (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)