Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42773 )
Change subject: mb/amd/mandolin: Strings with / need quoting in new kconfig ......................................................................
mb/amd/mandolin: Strings with / need quoting in new kconfig
Change-Id: I95f889d462ace1b912b5e6c7320973e8a826f3cb Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/amd/mandolin/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/42773/1
diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig index 6ec77bf..5c5a2b6 100644 --- a/src/mainboard/amd/mandolin/Kconfig +++ b/src/mainboard/amd/mandolin/Kconfig @@ -33,7 +33,7 @@
config MAINBOARD_DIR string - default amd/mandolin + default "amd/mandolin"
config MAINBOARD_PART_NUMBER string
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42773 )
Change subject: mb/amd/mandolin: Strings with / need quoting in new kconfig ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42773/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42773/1//COMMIT_MSG@7 PS1, Line 7: Strings with / need quoting in new kconfig Quote strings with / in Kconfig
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42773
to look at the new patch set (#2).
Change subject: mb/amd/mandolin: Quote string in Kconfig that contains / ......................................................................
mb/amd/mandolin: Quote string in Kconfig that contains /
Newer versions of Kconfig require that.
Change-Id: I95f889d462ace1b912b5e6c7320973e8a826f3cb Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/amd/mandolin/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/42773/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42773 )
Change subject: mb/amd/mandolin: Quote string in Kconfig that contains / ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42773/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42773/1//COMMIT_MSG@7 PS1, Line 7: Strings with / need quoting in new kconfig
Quote strings with / in Kconfig
Done
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42773 )
Change subject: mb/amd/mandolin: Quote string in Kconfig that contains / ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42773 )
Change subject: mb/amd/mandolin: Quote string in Kconfig that contains / ......................................................................
mb/amd/mandolin: Quote string in Kconfig that contains /
Newer versions of Kconfig require that.
Change-Id: I95f889d462ace1b912b5e6c7320973e8a826f3cb Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42773 Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/amd/mandolin/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig index a087b59..a137b4d 100644 --- a/src/mainboard/amd/mandolin/Kconfig +++ b/src/mainboard/amd/mandolin/Kconfig @@ -31,7 +31,7 @@
config MAINBOARD_DIR string - default amd/mandolin + default "amd/mandolin"
config MAINBOARD_PART_NUMBER string
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Stefan Reinauer (Code Review)