Attention is currently required from: Tim Wawrzynczak, Julius Werner.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62921 )
Change subject: commonlib/bsd/helpers: Remove redundancy with libpayload defines
......................................................................
Patch Set 3:
(1 comment)
File src/commonlib/bsd/include/commonlib/bsd/helpers.h:
https://review.coreboot.org/c/coreboot/+/62921/comment/09363c4f_d3aea61b
PS2, Line 15: #define ALIGN(x, a) __ALIGN_MASK(x, (__typeof__(x))(a)-1UL)
Right... […]
This seems to work, but it is also required to be included by stddef.h in libpayload. We will see, if Jenkins will accept it.
And, additionally I had to fix includes fixup macro: CB:63002
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62921
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3263b2aa7657759207bf6ffda750d839e741f99c
Gerrit-Change-Number: 62921
Gerrit-PatchSet: 3
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 22 Mar 2022 17:02:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment