Attention is currently required from: Raul Rangel, Jason Nien, Isaac Lee, Paul Menzel, Jon Murphy, Tim Wawrzynczak, Martin Roth, Eric Peers, Moises Garcia, Karthikeyan Ramasubramanian.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68077 )
Change subject: ec/google/chromec: Expand EC share memory for DTTS
......................................................................
Patch Set 18:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68077/comment/41abdcfe_694e45af
PS15, Line 7: mb/google/skyrim/var/winterhold: DTT Switching Proposal
Please make this a statement by adding a verb (in imperative mood) [1]. […]
Change to "Expand EC share memory for DTTS"
https://review.coreboot.org/c/coreboot/+/68077/comment/c76be3c6_fe20dc4b
PS15, Line 8:
Please describe the problem, that needs solving.
Done
https://review.coreboot.org/c/coreboot/+/68077/comment/134c2233_2c52a0a8
PS15, Line 9: Define mode change STTB bit for Desktop(1) and laptop(0)
: This bit is Switch thermal table by body detection status
Please add a dot/period at the end of sentences, and add a space before the (.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68077
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37b3a0d8f6546361c8d5501e98e3e1b0d814fce3
Gerrit-Change-Number: 68077
Gerrit-PatchSet: 18
Gerrit-Owner: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Isaac Lee
isaaclee@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Moises Garcia
moisesgarcia@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Isaac Lee
isaaclee@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Moises Garcia
moisesgarcia@google.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Comment-Date: Wed, 26 Oct 2022 05:22:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment