Change in coreboot[master]: security/intel/txt/romstage.c: Unlock memory when SCLEAN not needed

[Michał Żygowski (Code Review)]

Attention is currently required from: Angel Pons, Patrick Rudolph.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59521 )

Change subject: security/intel/txt/romstage.c: Unlock memory when SCLEAN not needed
......................................................................

Patch Set 3:

(2 comments)

File src/security/intel/txt/romstage.c:

https://review.coreboot.org/c/coreboot/+/59521/comment/62bc46a0_8a206c93 
PS3, Line 134: 	} else if (!establishment) {
> If TPM establishment is asserted but there's no TXT wake error, this function won't unlock memory.

Right, it should be done regardless of TPM establishment.

https://review.coreboot.org/c/coreboot/+/59521/comment/79ba777d_dc63d71c 
PS3, Line 138: 		wrmsr(TXT_UNLOCK_MEMORY_MSR, msr);
> Doesn't native raminit already do this? […]

Yes it does, we have a separate discussion in this patch. I am not sure though if the MSR should be always written. You could advise there how to approach the code duplication.