[M] Change in coreboot[master]: resource: Add helpers for memory resources - coreboot-gerrit

6 Jun 2023


      Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55474?usp=email )
Change subject: resource: Add helpers for memory resources
......................................................................
Patch Set 13:
(1 comment)
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/55474/comment/a7c5c975_02691db1 :
PS13, Line 378: end
...
Maybe `mmio_from_to_exclusive` since it doesn't include the last address?
Maybe try discuss the necessity of topic:new-resource in general instead? Device resource structs are bloated and IORESOURCE_FLAGS are not well defined.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55474?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40644f873c0ea993353753c0ef40df4c83233355
Gerrit-Change-Number: 55474
Gerrit-PatchSet: 13
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Raul Rangel rrangel@chromium.org
Gerrit-Comment-Date: Tue, 06 Jun 2023 20:25:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment