Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19072 )
Change subject: ec: add support for KBC1126 in HP laptops ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/19072/3/src/ec/hp/kbc1126/Makefile.inc File src/ec/hp/kbc1126/Makefile.inc:
PS3, Line 28: $(KBC1126_EC_INSERT) $(obj)/coreboot.pre \ : $(CONFIG_KBC1126_FW1) $(CONFIG_KBC1126_FW2) \ : $(CONFIG_KBC1126_FW1_OFFSET) $(CONFIG_KBC1126_FW2_OFFSET)
It can, so users need to configure FW2_OFFSET to be at lease 64K smaller th
Maybe using Makefile to include the files at a certain offset is the way to go. how mrc.cache is added is a good example. It provides a 'position' option to specify base.