Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro.
Subrata Banik has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/84935?usp=email )
Change subject: soc/intel/alderlake: Do lazy reset after disabling UFS ......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/include/soc/romstage.h:
https://review.coreboot.org/c/coreboot/+/84935/comment/5109dcd6_89cc96a1?usp... : PS1, Line 23: mainboard_expects_another_reset Maybe a comment section would be helpful to understand when to override this function from the main board. I guess you are latching on below factors
1. During the cold boot cycle, don't need reset post disabling UFS because global reset will take care of it ? Therefore, you don't need to issue an immediate reset
2. During warm boot cycle, you don't need to issue resets because PMC FW won't be loaded further hence, if UFS has been disabled in last boot then PMC FW won't sample the new state ?