Attention is currently required from: Robert Zieba, Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68138 )
Change subject: soc/amd/cezanne: Factor out common GPP clk req code
......................................................................
Patch Set 6:
(1 comment)
File src/soc/amd/common/block/pci/Kconfig:
https://review.coreboot.org/c/coreboot/+/68138/comment/1c4d7767_8368af43
PS6, Line 16: depends on SOC_AMD_COMMON_BLOCK_PCI
Can we `select SOC_AMD_COMMON_BLOCK_PCIE_CLK_REQ` here instead of in every single SOC Kconfig?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68138
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a4c72d8e980993c76a1b128f17b65b0db972a03
Gerrit-Change-Number: 68138
Gerrit-PatchSet: 6
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Tue, 25 Oct 2022 16:17:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment