Attention is currently required from: Michał Kopeć, Michał Żygowski, Piotr Król.
Hello Michał Kopeć,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/81963?usp=email
to review the following change.
Change subject: mb/protectli/vault_cml: use combo v1/v2 FSP ......................................................................
mb/protectli/vault_cml: use combo v1/v2 FSP
Change-Id: I1a6f6e873e4ec35b9777dc17c0495151348d1d88 Signed-off-by: Michał Kopeć michal.kopec@3mdeb.com --- M src/mainboard/protectli/vault_cml/Kconfig M src/mainboard/protectli/vault_cml/Kconfig.name 2 files changed, 4 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/81963/1
diff --git a/src/mainboard/protectli/vault_cml/Kconfig b/src/mainboard/protectli/vault_cml/Kconfig index 2389520..08e130d 100644 --- a/src/mainboard/protectli/vault_cml/Kconfig +++ b/src/mainboard/protectli/vault_cml/Kconfig @@ -1,11 +1,11 @@ ## SPDX-License-Identifier: GPL-2.0-only
-if BOARD_PROTECTLI_VP4630_VP4650 || BOARD_PROTECTLI_VP4670 +if BOARD_PROTECTLI_VP46XX
config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 - select GFX_GMA_IGNORE_PRESENCE_STRAPS + select SOC_INTEL_COMETLAKE_1_2 select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_CMOS_DEFAULT diff --git a/src/mainboard/protectli/vault_cml/Kconfig.name b/src/mainboard/protectli/vault_cml/Kconfig.name index f0f3257..1aaac81 100644 --- a/src/mainboard/protectli/vault_cml/Kconfig.name +++ b/src/mainboard/protectli/vault_cml/Kconfig.name @@ -1,7 +1,4 @@ ## SPDX-License-Identifier: GPL-2.0-only
-config BOARD_PROTECTLI_VP4630_VP4650 - bool "VP4630/VP4650" - -config BOARD_PROTECTLI_VP4670 - bool "VP4670" +config BOARD_PROTECTLI_VP46XX + bool "VP4630/VP4650/VP4670"