Change in ...coreboot[master]: mb/google/hatch: Select SD_PWR_EN workaround

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Rizwan Qureshi (Code Review)

17 Feb 2019 17 Feb '19

3:50 p.m.

Rizwan Qureshi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31446

Change subject: mb/google/hatch: Select SD_PWR_EN workaround ......................................................................

mb/google/hatch: Select SD_PWR_EN workaround

Hatch implements acive high SD_PWR_EN and requires a workaround in _PS0 and _PS3 control methods to make sure SD_PWR_EN stays low in D3.

BUG=b:123350329

Change-Id: I96ab9660eb50100207fe9a237f5924b65eae0928 Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/31446/1

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 65a3562..a1e58a3 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -14,6 +14,7 @@ select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_SPI_TPM_CR50 select MAINBOARD_HAS_TPM2 + select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE select SOC_INTEL_WHISKEYLAKE select SYSTEM_TYPE_LAPTOP

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Furquan Shaikh (Code Review)

18 Feb 18 Feb

4:44 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31446 )

Change subject: mb/google/hatch: Select SD_PWR_EN workaround ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96ab9660eb50100207fe9a237f5924b65eae0928 Gerrit-Change-Number: 31446 Gerrit-PatchSet: 2 Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 17 Feb 2019 19:44:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

9:45 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31446 )

Change subject: mb/google/hatch: Select SD_PWR_EN workaround ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31446/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31446/2//COMMIT_MSG@9 PS2, Line 9: acive active

-- To view, visit https://review.coreboot.org/c/coreboot/+/31446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96ab9660eb50100207fe9a237f5924b65eae0928 Gerrit-Change-Number: 31446 Gerrit-PatchSet: 2 Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 18 Feb 2019 12:45:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Rizwan Qureshi (Code Review)

10:08 p.m.

Hello Patrick Rudolph, Duncan Laurie, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31446

to look at the new patch set (#3).

Change subject: mb/google/hatch: Select SD_PWR_EN workaround ......................................................................

mb/google/hatch: Select SD_PWR_EN workaround

Hatch implements acive high SD_PWR_EN and requires a workaround in _PS0 and _PS3 control methods to make sure SD_PWR_EN stays low in D3.

BUG=b:123350329

Change-Id: I96ab9660eb50100207fe9a237f5924b65eae0928 Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/31446/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/31446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96ab9660eb50100207fe9a237f5924b65eae0928 Gerrit-Change-Number: 31446 Gerrit-PatchSet: 3 Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Rizwan Qureshi (Code Review)

10:59 p.m.

Hello Patrick Rudolph, Duncan Laurie, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31446

to look at the new patch set (#4).

Change subject: mb/google/hatch: Select SD_PWR_EN workaround ......................................................................

mb/google/hatch: Select SD_PWR_EN workaround

Hatch implements active high SD_PWR_EN and requires a workaround in _PS0 and _PS3 control methods to make sure SD_PWR_EN stays low in D3.

BUG=b:123350329

Change-Id: I96ab9660eb50100207fe9a237f5924b65eae0928 Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/31446/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/31446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96ab9660eb50100207fe9a237f5924b65eae0928 Gerrit-Change-Number: 31446 Gerrit-PatchSet: 4 Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Rizwan Qureshi (Code Review)

10:59 p.m.

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31446 )

Change subject: mb/google/hatch: Select SD_PWR_EN workaround ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/31446/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31446/2//COMMIT_MSG@9 PS2, Line 9: acive

...

active

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/31446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96ab9660eb50100207fe9a237f5924b65eae0928 Gerrit-Change-Number: 31446 Gerrit-PatchSet: 4 Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 18 Feb 2019 13:59:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

22 Feb 22 Feb

1:29 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31446 )

Change subject: mb/google/hatch: Select SD_PWR_EN workaround ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96ab9660eb50100207fe9a237f5924b65eae0928 Gerrit-Change-Number: 31446 Gerrit-PatchSet: 5 Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 21 Feb 2019 16:29:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Rizwan Qureshi (Code Review)

26 Feb 26 Feb

10:02 p.m.

New subject: Change in ...coreboot[master]: mb/google/hatch: Select SD_PWR_EN Active high config

Hello Patrick Rudolph, Duncan Laurie, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31446

to look at the new patch set (#10).

Change subject: mb/google/hatch: Select SD_PWR_EN Active high config ......................................................................

mb/google/hatch: Select SD_PWR_EN Active high config

Hatch implements active high SD_PWR_EN and requires a workaround in _PS0 and _PS3 control methods to make sure SD_PWR_EN stays low in D3. Select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE to enable the same.

BUG=b:123350329

Change-Id: I96ab9660eb50100207fe9a237f5924b65eae0928 Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/31446/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/31446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96ab9660eb50100207fe9a237f5924b65eae0928 Gerrit-Change-Number: 31446 Gerrit-PatchSet: 10 Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Rizwan Qureshi (Code Review)

27 Feb 27 Feb

4:03 a.m.

New subject: Change in ...coreboot[master]: mb/google/hatch: Select SD_PWR_EN Active high config

Hello Patrick Rudolph, Duncan Laurie, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31446

to look at the new patch set (#15).

Change subject: mb/google/hatch: Select SD_PWR_EN Active high config ......................................................................

mb/google/hatch: Select SD_PWR_EN Active high config

Hatch implements active high SD_PWR_EN and requires a workaround in _PS0 and _PS3 control methods to make sure SD_PWR_EN stays low in D3. Select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE to enable the same.

BUG=b:123350329

Change-Id: I96ab9660eb50100207fe9a237f5924b65eae0928 Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/31446/15

-- To view, visit https://review.coreboot.org/c/coreboot/+/31446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96ab9660eb50100207fe9a237f5924b65eae0928 Gerrit-Change-Number: 31446 Gerrit-PatchSet: 15 Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

4:38 a.m.

New subject: Change in ...coreboot[master]: mb/google/hatch: Select SD_PWR_EN Active high config

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31446 )

Change subject: mb/google/hatch: Select SD_PWR_EN Active high config ......................................................................

Patch Set 15: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96ab9660eb50100207fe9a237f5924b65eae0928 Gerrit-Change-Number: 31446 Gerrit-PatchSet: 15 Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 26 Feb 2019 19:38:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

8:05 p.m.

New subject: Change in ...coreboot[master]: mb/google/hatch: Select SD_PWR_EN Active high config

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31446 )

Change subject: mb/google/hatch: Select SD_PWR_EN Active high config ......................................................................

mb/google/hatch: Select SD_PWR_EN Active high config

Hatch implements active high SD_PWR_EN and requires a workaround in _PS0 and _PS3 control methods to make sure SD_PWR_EN stays low in D3. Select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE to enable the same.

BUG=b:123350329

Change-Id: I96ab9660eb50100207fe9a237f5924b65eae0928 Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com Reviewed-on: https://review.coreboot.org/c/31446 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index b97977c..2290d8c 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -14,6 +14,7 @@ select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_SPI_TPM_CR50 select MAINBOARD_HAS_TPM2 + select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE select SOC_INTEL_WHISKEYLAKE select SYSTEM_TYPE_LAPTOP

-- To view, visit https://review.coreboot.org/c/coreboot/+/31446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96ab9660eb50100207fe9a237f5924b65eae0928 Gerrit-Change-Number: 31446 Gerrit-PatchSet: 17 Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

2048

days inactive

2058

days old

coreboot-gerrit@coreboot.org

10 comments

4 participants

tags (0)

participants (4)

Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Rizwan Qureshi (Code Review)