Attention is currently required from: Hung-Te Lin. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60447 )
Change subject: mb/google/corsola: initialize krabby display ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: hi Hung-te and Yu-ping,
There are some build errors for "Corsola". I think we just build for "Kingler" and "Krabby" Aby suggestion?
CC ramstage/mainboard/google/corsola/display.o src/mainboard/google/corsola/display.c:100:1: error: static assertion failed: "Exactly one of KINGLER and KRABBY must be set" 100 | _Static_assert(CONFIG(BOARD_GOOGLE_KINGLER_COMMON) + CONFIG(BOARD_GOOGLE_KRABBY_COMMON) == 1, | ^~~~~~~~~~~~~~ make[1]: *** [Makefile:381: /cb-build/coreboot-gerrit.0/chromeos/GOOGLE_CORSOLA/ramstage/mainboard/google/corsola/display.o] Error 1 make[1]: Leaving directory '/home/coreboot/node-root/workspace/coreboot-gerrit'
-
Rex-BC Chen (Code Review)