Attention is currently required from: Alexander Couzens, Nicholas Chin.
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80437?usp=email )
Change subject: ec/lenovo/h8/acpi: Support pulsing LEDLOGO on Haswell ThinkPads ......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS3: There's a change between first and current patchsets.
The first patchset puts LEDLOGO in blinking mode during the waking stage, just like the existing code does with the suspend LED. But to be honest, I don't remember it blinking when waking up with vendor firmware.
So in the last patchset, I changed the behavior, putting it to simple "on" state during the waking stage, just like the power button LED.
If somebody remembers different behavior with vendor fw, please tell me in comments, but I think the last version is correct.
File src/mainboard/lenovo/haswell/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/80437/comment/d795c819_ae31f1b5 : PS1, Line 3: #define H8_HAS_LEDLOGO
It might be be better to implement this as a Kconfig and use something like `#if CONFIG(H8_HAS_LEDLO […]
No problem, turned it into a Kconfig.