Change in coreboot[master]: soc/intel/common/block/p2sb: Add helper function to enable BAR - coreboot-gerrit

17 Mar 2022


      Attention is currently required from: Wonkyu Kim, Tim Wawrzynczak, John Zhao, Angel Pons, Nick Vaccaro, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62778 )
Change subject: soc/intel/common/block/p2sb: Add helper function to enable BAR
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
...
Just curious why need this in bootblock and romstage?
It's to compliment p2sb.c and ioe_p2sb.c file which has added for all stages but library code (p2sblib.c) only added for later stage.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62778
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica41e8e8bdfcfe855e730b3878b874070062ef93
Gerrit-Change-Number: 62778
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: John Zhao john.zhao@intel.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Wonkyu Kim
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: John Zhao john.zhao@intel.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Thu, 17 Mar 2022 06:14:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment