Attention is currently required from: Paul Menzel, Marco Chen.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56380 )
Change subject: mb/google/octopus/var/phaser: Change IRQ trigger method to level
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56380/comment/7e5da890_b3fdb6a8
PS4, Line 2: joey.peng
Please use Joey Peng.
Done
https://review.coreboot.org/c/coreboot/+/56380/comment/94f225c2_b854b39f
PS4, Line 14:
The commit above is for G2Touch not for Elan so might not be relevant. […]
According to Marco's comment, change this comment to resolved
https://review.coreboot.org/c/coreboot/+/56380/comment/234fd799_1de5fc0e
PS4, Line 16: TEST=Build coreboot and check that device works
Did the touchpad work before that change?
We never used Elan touchpad.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56380
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44ee779242779c78ceafdddd34dca2571e714dd3
Gerrit-Change-Number: 56380
Gerrit-PatchSet: 5
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alec Wang
alec.wang@lcfc.corp-partner.google.com
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Marco Chen
marcochen@google.com
Gerrit-Attention: Marco Chen
marcochen@chromium.org
Gerrit-Comment-Date: Thu, 12 Aug 2021 07:22:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Gerrit-MessageType: comment