Attention is currently required from: Angel Pons, Arthur Heymans, David Milosevic, Maximilian Brune, Naresh Solanki, Paul Menzel.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79103?usp=email )
Change subject: mb/arm/rdn2: Add support for Arm Neoverse N2
......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/arm/rdn2/acpi.c:
https://review.coreboot.org/c/coreboot/+/79103/comment/baac55ce_60e65ca9 :
PS5, Line 29: platform_get_gicd_base
Why does it use GICv2 compatibility mode?
https://review.coreboot.org/c/coreboot/+/79103/comment/3a688efa_77195f6d :
PS5, Line 30: gicv
only needed on GICv2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79103?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I17908d3ce773d4a88924bafb1d0e9e2a043c7fbc
Gerrit-Change-Number: 79103
Gerrit-PatchSet: 5
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Mon, 15 Jan 2024 08:05:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment