Attention is currently required from: Bao Zheng, Zheng Bao.
Felix Held has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84338?usp=email )
Change subject: amdfwtool: Check fletcher of each header ......................................................................
Patch Set 1:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/84338/comment/71ccbde2_0c5c8c69?usp... : PS1, Line 571: default: /* ISH */ hmm, the ISH table has its checksum where all other tables have the cookie field, so if we're unlucky and the ISH checksum has a value of one of the cookie values, we'll end up in the wrong case. so i wonder if the function should have a bool is_ish parameter to tell it if it's an ISH table to know for sure that it's an ISH table