[M] Change in coreboot[main]: acpi: Move HPET generation to a common location

[Martin Roth (Code Review)]

Attention is currently required from: Arthur Heymans, Christian Walter, Cliff Huang, Felix Held, Felix Singer, Fred Reitberger, Jason Glenesk, Jeff Daly, Johnny Lin, Jonathan Zhang, Lance Zhao, Lean Sheng Tan, Matt DeVillier, Nico Huber, Patrick Rudolph, Raul Rangel, Tim Chu, Tim Wawrzynczak, Vanessa Eusebio.

Martin Roth has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/76128?usp=email )

Change subject: acpi: Move HPET generation to a common location
......................................................................

Patch Set 13:

(2 comments)

File src/acpi/Kconfig:

https://review.coreboot.org/c/coreboot/+/76128/comment/3bbd14d3_7073a419?usp... :
PS13, Line 134: depends on HAVE_ACPI_TABLES
This doesn't apply if it's enabled with a select. The select forces it on. If you want this to matter, you'd set it to defaulting it to on in each place it's being selected now.

File src/southbridge/intel/i82371eb/Kconfig:

https://review.coreboot.org/c/coreboot/+/76128/comment/7df2600f_589c00a6?usp... :
PS13, Line 6: select ACPI_HPET if HAVE_ACPI_TABLES
It seems like either "if HAVE_ACPI_TABLES" should be needed in more places or we should set it to ignore ACPI_HPET if HAVE_ACPI_TABLES is disabled so that the if isn't needed here.

It just seems odd that this is the only place it would be needed.