Attention is currently required from: Karthik Ramasubramanian, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56818 )
Change subject: soc/amd/common/block/spi: Don't update spi speed if EFS is changed ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
haven't checked the details yet, but i do like the approach. […]
My thought was to print the SPI speed and mode when the console is initialized. I can also do the comparison again at that point though and print out that it was skipped.
File src/soc/amd/common/block/spi/fch_spi.c:
https://review.coreboot.org/c/coreboot/+/56818/comment/9d3cc39c_a0482530 PS2, Line 25: spi_speed_offset
Can this be offset be defined as a config item i.e. CONFIG_EFS_SPI_SPEED_OFFSET with default as -1. […]
Sure, though I'd really prefer to do it with the precompiler and not add another "config" variable that isn't really a variable. I'll make an EFS header file and put all of the EFS header information in there.