Attention is currently required from: Furquan Shaikh.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52782 )
Change subject: soc/intel/common/block: Add definition for NAF_VWE bit for PAD_CFG0 reg
......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/52782/comment/19639cac_171aed35
PS3, Line 38: PAD_CFG0_NAFVWE_ENABLE
Yes Tim...It's common definition between multiple platforms...Like it's applicable for TGL also.
Done
https://review.coreboot.org/c/coreboot/+/52782/comment/200887cc_d1bc1687
PS3, Line 224: PAD_IOSSTATE(TxLASTRxE)
I have tried to maintain same definition as PAD_CFG_NF for this. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52782
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I732e68b413eb01b8ae1a4927836762c8875b73d2
Gerrit-Change-Number: 52782
Gerrit-PatchSet: 4
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 04 May 2021 16:07:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment