[M] Change in coreboot[master]: cpu/x86/mp_init.c: Keep track of initial lapic ID inside device_path
Attention is currently required from: Arthur Heymans, Angel Pons, Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64342 )
Change subject: cpu/x86/mp_init.c: Keep track of initial lapic ID inside device_path ......................................................................
Patch Set 11:
(5 comments)
File src/arch/x86/cpu.c:
https://review.coreboot.org/c/coreboot/+/64342/comment/e91da275_1d9a7f00 PS5, Line 224: return NULL;
Given the usage below, maybe it's best to die instead of returning NULL? How important is the CPU cl […]
Done
https://review.coreboot.org/c/coreboot/+/64342/comment/447ecb0a_73f98487 PS5, Line 233: cpu_cluster()
Can return NULL
Done
https://review.coreboot.org/c/coreboot/+/64342/comment/868b11c2_dda34117 PS5, Line 254: return dev->path.apic.initial_lapicid;
When there are `N` CPU devices (`0` to `N - 1`) and one calls this function with `N` as `logical_cpu […]
Done
File src/cpu/x86/lapic/lapic_cpu_init.c:
https://review.coreboot.org/c/coreboot/+/64342/comment/f41f2367_2e3ab863 PS8, Line 255: cpu_add_map_entry(info->index);
Where is `initial_lapicid` set? […]
Done
https://review.coreboot.org/c/coreboot/+/64342/comment/6babe4c6_3e4f6fb5 PS8, Line 396: cpu_add_map_entry(info->index);
Where is `initial_lapicid` set?
Done
-
Arthur Heymans (Code Review)