Attention is currently required from: Hung-Te Lin, Rex-BC Chen. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60318 )
Change subject: soc/mediatek/mt8186: Add DRAM full calibration support ......................................................................
Patch Set 2: Verified-1
(19 comments)
File src/soc/mediatek/mt8186/include/soc/dramc_soc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/66bc6378_ab4e3f08 PS2, Line 7: CHANNEL_A = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/7b1c8337_48b3ccc6 PS2, Line 8: CHANNEL_B, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/3de040c6_be3fe8d2 PS2, Line 9: CHANNEL_MAX, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/f75d2aed_15d32f2b PS2, Line 13: RANK_0 = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/2d7322eb_f8b1e13b PS2, Line 14: RANK_1, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/e49060d8_c9756bd6 PS2, Line 15: RANK_MAX, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/429049df_7e06b291 PS2, Line 20: DRAM_DFS_SHUFFLE_1 = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/fe04becd_65a48461 PS2, Line 21: DRAM_DFS_SHUFFLE_2, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/69f47cec_4f184ec8 PS2, Line 22: DRAM_DFS_SHUFFLE_3, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/4fdff863_77590c16 PS2, Line 23: DRAM_DFS_SHUFFLE_4, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/5b288dd0_aed57608 PS2, Line 24: DRAM_DFS_SHUFFLE_5, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/75cd109f_fb7ebaf5 PS2, Line 25: DRAM_DFS_SHUFFLE_6, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/89610a7e_2f84e943 PS2, Line 26: DRAM_DFS_SHUFFLE_7, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/395fa9b4_6caa4109 PS2, Line 27: DRAM_DFS_SHUFFLE_8, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/83b2c048_30710862 PS2, Line 28: DRAM_DFS_SHUFFLE_9, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/457d2437_05047f37 PS2, Line 29: DRAM_DFS_SHUFFLE_10, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/3717852f_a86e40a5 PS2, Line 30: DRAM_DFS_SHUFFLE_MAX, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/9e42f924_c612062e PS2, Line 41: CBT_NORMAL_MODE = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136075): https://review.coreboot.org/c/coreboot/+/60318/comment/2d097dc0_e39ea927 PS2, Line 42: CBT_BYTE_MODE1, please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)