Attention is currently required from: Julius Werner, Nicholas Chin.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80577?usp=email )
Change subject: include/device/azalia.h: Add enum for misc field
......................................................................
Patch Set 1:
(1 comment)
File src/include/device/azalia.h:
https://review.coreboot.org/c/coreboot/+/80577/comment/cecc89a2_57a867ae :
PS1, Line 110: enum AzaliaPinCfgMisc misc:4;
I just saw this patch go by and I don't know what this driver is about, but just wanted to mention t […]
It's a shame that bit fields are not really well specified. It seems like it's better to just avoid using them.
Though, I have proposed a change to drop this file entirely (CB:80695).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80577?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iff9d146fe8fbff3d11655ddfcc415b1a2c582ccf
Gerrit-Change-Number: 80577
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Thu, 22 Feb 2024 05:38:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment