Attention is currently required from: Shelley Chen, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56965 )
Change subject: device: Move MIPI panel library from mainboard/google/kukui into common ......................................................................
Patch Set 1:
(6 comments)
Commit Message:
PS1:
rk3399 also has lots of duplicate code. […]
I don't really feel like spending the time right now tbh, it's an old chipset and it's very unlikely anyone will ever use it again. Let's establish this going forward for now, and if anyone cares backporting it to the older stuff they're welcome to do so.
https://review.coreboot.org/c/coreboot/+/56965/comment/493318d3_87bb3096 PS1, Line 15: at
a?
Done
File src/device/mipi/Kconfig:
https://review.coreboot.org/c/coreboot/+/56965/comment/5d6115f9_01041837 PS1, Line 38:
Extra blank line.
Done
File src/include/device/mipi_panel.h:
https://review.coreboot.org/c/coreboot/+/56965/comment/17c15a2f_af33ff7d PS1, Line 11: PANEL_END_CMD
I'd prefer consistent prefixes: PANEL_CMD_*.
Done
https://review.coreboot.org/c/coreboot/+/56965/comment/7771a9a7_8f1f954e PS1, Line 24: that
remove
Done
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/56965/comment/b6848f24_40baf7ff PS1, Line 359: TODO
It's considered an error according in rk_mipi_dsi_write().
Let me switch it to CB_ERR.