[S] Change in coreboot[master]: acpi.c: Fill in >4G FADT entries correctly - coreboot-gerrit

2 Aug 2023


      Attention is currently required from: Arthur Heymans, Felix Held, Lance Zhao, Lean Sheng Tan, Nico Huber, Tim Wawrzynczak.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76179?usp=email )
Change subject: acpi.c: Fill in >4G FADT entries correctly
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76179/comment/774211bc_88d9cd74 :
PS5, Line 1092: 		fadt->x_firmware_ctl_h = (uint32_t)((uint64_t)(uintptr_t)facs >> 32);
...
...
Wouldn't write shift work here without warnings with just: […]
Acknowledged
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/76179?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I84ab0068e8409a5e525ddc781347087680d80640
Gerrit-Change-Number: 76179
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 02 Aug 2023 08:20:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment