Change in ...coreboot[master]: mb/google/hatch: Add keyboard backlight support
Ivy Jian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31175 Change subject: mb/google/hatch: Add keyboard backlight support ...................................................................... mb/google/hatch: Add keyboard backlight support This change adds keyboard backlight feature for Hatch platform BUG=b:122799544 BRANCH=none TEST=keyboard backlight works when EC reports correct info. Change-Id: I29273122f061e0e442f6629351ef3670535c0507 Signed-off-by: Ivy Jian <ivy_jian@compal.corp-partner.google.com> --- M src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/31175/1 diff --git a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h index f9cebd7..75d583e 100644 --- a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h @@ -78,4 +78,7 @@ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ +/* Enable EC backed Keyboard Backlight in ACPI */ +#define EC_ENABLE_KEYBOARD_BACKLIGHT + #endif /* __BASEBOARD_EC_H__ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/31175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29273122f061e0e442f6629351ef3670535c0507 Gerrit-Change-Number: 31175 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy_jian@compal.corp-partner.google.com> Gerrit-MessageType: newchange
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31175 ) Change subject: mb/google/hatch: Add keyboard backlight support ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/31175/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/31175/1//COMMIT_MSG@9 PS1, Line 9: This change adds keyboard backlight feature for Hatch platform Please add a dot/period at the end of a sentence. -- To view, visit https://review.coreboot.org/c/coreboot/+/31175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29273122f061e0e442f6629351ef3670535c0507 Gerrit-Change-Number: 31175 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy_jian@compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Ivy Jian <ivy_jian@compal.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 31 Jan 2019 10:49:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Hello Paul Menzel, Shelley Chen, build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/31175 to look at the new patch set (#2). Change subject: mb/google/hatch: Add keyboard backlight support ...................................................................... mb/google/hatch: Add keyboard backlight support This change adds keyboard backlight feature for Hatch platform. BUG=b:122799544 BRANCH=none TEST=keyboard backlight works when EC reports correct info. Change-Id: I29273122f061e0e442f6629351ef3670535c0507 Signed-off-by: Ivy Jian <ivy_jian@compal.corp-partner.google.com> --- M src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/31175/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/31175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29273122f061e0e442f6629351ef3670535c0507 Gerrit-Change-Number: 31175 Gerrit-PatchSet: 2 Gerrit-Owner: Ivy Jian <ivy_jian@compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Ivy Jian <ivy_jian@compal.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31175 ) Change subject: mb/google/hatch: Add keyboard backlight support ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/31175/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/31175/1//COMMIT_MSG@9 PS1, Line 9: This change adds keyboard backlight feature for Hatch platform
Please add a dot/period at the end of a sentence. Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/31175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29273122f061e0e442f6629351ef3670535c0507 Gerrit-Change-Number: 31175 Gerrit-PatchSet: 2 Gerrit-Owner: Ivy Jian <ivy_jian@compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Ivy Jian <ivy_jian@compal.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Fri, 01 Feb 2019 01:28:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: comment
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31175 ) Change subject: mb/google/hatch: Add keyboard backlight support ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/31175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29273122f061e0e442f6629351ef3670535c0507 Gerrit-Change-Number: 31175 Gerrit-PatchSet: 2 Gerrit-Owner: Ivy Jian <ivy_jian@compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Ivy Jian <ivy_jian@compal.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 04 Feb 2019 00:55:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31175 ) Change subject: mb/google/hatch: Add keyboard backlight support ...................................................................... mb/google/hatch: Add keyboard backlight support This change adds keyboard backlight feature for Hatch platform. BUG=b:122799544 BRANCH=none TEST=keyboard backlight works when EC reports correct info. Change-Id: I29273122f061e0e442f6629351ef3670535c0507 Signed-off-by: Ivy Jian <ivy_jian@compal.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/31175 Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> --- M src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved diff --git a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h index f9cebd7..75d583e 100644 --- a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h @@ -78,4 +78,7 @@ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ +/* Enable EC backed Keyboard Backlight in ACPI */ +#define EC_ENABLE_KEYBOARD_BACKLIGHT + #endif /* __BASEBOARD_EC_H__ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/31175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29273122f061e0e442f6629351ef3670535c0507 Gerrit-Change-Number: 31175 Gerrit-PatchSet: 3 Gerrit-Owner: Ivy Jian <ivy_jian@compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Ivy Jian <ivy_jian@compal.corp-partner.google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: merged
participants (4)
-
Furquan Shaikh (Code Review) -
Ivy Jian (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)