Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58114 )
Change subject: soc/amd/common/block/espi_util: Refactor ESPI Setup ......................................................................
Patch Set 4:
(4 comments)
File src/soc/amd/cezanne/early_fch.c:
https://review.coreboot.org/c/coreboot/+/58114/comment/8b6ffdbd_ddfb4ac8 PS2, Line 39: enable_acpimmio_decode_pm04();
this should probably be done in another patch, but enable_acpimmio_decode_pm04 needs to be moved to […]
Done
File src/soc/amd/common/block/lpc/lpc_util.c:
https://review.coreboot.org/c/coreboot/+/58114/comment/49c859c0_fa8b6ecd PS2, Line 365: configure_espi
yes, moving this function to espi_util. […]
Done
https://review.coreboot.org/c/coreboot/+/58114/comment/6552a642_29326d17 PS2, Line 367: ESPI
i think it's eSPI with a lower case e. […]
Done
https://review.coreboot.org/c/coreboot/+/58114/comment/08021867_50945a4a PS2, Line 369: !CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK) &&
this gets skipped in the case of verstage on psp to not initialize eSPI twice, right?
Yes, if eSPI is already initialized in PSP verstage we dont need to re-initialize it in x86 again.