Attention is currently required from: Patrick Rudolph. John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52712 )
Change subject: drivers/intel/usb4: Update driver to support Retimer firmware upgrade ......................................................................
Patch Set 1:
(5 comments)
File src/drivers/intel/usb4/retimer/retimer.c:
https://review.coreboot.org/c/coreboot/+/52712/comment/7e5ef1ea_de5d70e4 PS1, Line 69: * Return: -1 if timeout error occuring
'occuring' may be misspelled - perhaps 'occurring'?
Please fix.
https://review.coreboot.org/c/coreboot/+/52712/comment/5870df41_5a69172e PS1, Line 243: * // Disable retimer online state
please, no space before tabs
Please fix.
https://review.coreboot.org/c/coreboot/+/52712/comment/642ad16f_5264ff6d PS1, Line 312: usb4_retimer_cb_get_power_state, /* Function 1 */
please, no space before tabs
Please fix.
https://review.coreboot.org/c/coreboot/+/52712/comment/3c72bd05_c6d4d0ea PS1, Line 313: usb4_retimer_cb_set_power_state, /* Function 2 */
please, no space before tabs
Please fix.
https://review.coreboot.org/c/coreboot/+/52712/comment/d0da81b5_c533e74a PS1, Line 355: for(port = 0; port < config->dfp_num; port++) {
space required before the open parenthesis '('
Please fix.