HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30651 )
Change subject: mb/acer: add e1-571g mainboard
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/30651/3/src/mainboard/acer/e1-571g/...
File src/mainboard/acer/e1-571g/early_init.c:
https://review.coreboot.org/c/coreboot/+/30651/3/src/mainboard/acer/e1-571g/...
PS3, Line 15: #include <device/mmio.h>
: #include <device/pci_ops.h>
: #include <console/console.h>
: #include <bootblock_common.h>
: #include <northbridge/intel/sandybridge/sandybridge.h>
: #include <northbridge/intel/sandybridge/raminit_native.h>
: #include <southbridge/intel/bd82x6x/pch.h>
: #include <southbridge/intel/common/gpio.h>
please include only what you use
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30651
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b04e12f1cb937150ab54e5862a64b62e4fe9e8e
Gerrit-Change-Number: 30651
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 12 May 2020 10:00:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment