Attention is currently required from: V Sowmya, Saurabh Mishra, Subrata Banik, harsha.b.r@intel.com, Kangheui Won, Reka Norman, Rizwan Qureshi, Krishna P Bhat D, Ronak Kanabar, Usha P.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62323 )
Change subject: soc/intel/common : Remove use of CPUID_EXTENDED_CPU_TOPOLOGY_V2
......................................................................
Patch Set 6:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62323/comment/fdbac5b8_5e77bc60
PS6, Line 7: soc/intel/common :
Please remove the space.
https://review.coreboot.org/c/coreboot/+/62323/comment/e261ef6d_a8edd80d
PS6, Line 11: CPUID_EXTENDED_CPU_TOPOLOGY(0x0B)
Please add a space before (. (Also in the rest of the text.)
https://review.coreboot.org/c/coreboot/+/62323/comment/825c1ec2_2c7f8099
PS6, Line 17: provide
provides
https://review.coreboot.org/c/coreboot/+/62323/comment/456e0067_29be2b61
PS6, Line 19: inorder
in order
https://review.coreboot.org/c/coreboot/+/62323/comment/5654a165_3f17985d
PS6, Line 19: Coreboot
coreboot
https://review.coreboot.org/c/coreboot/+/62323/comment/4de1d73a_dc5f5083
PS6, Line 25: Coreboot
coreboot
https://review.coreboot.org/c/coreboot/+/62323/comment/212b578f_daef9c8b
PS6, Line 29: Solve
solve
https://review.coreboot.org/c/coreboot/+/62323/comment/2f549299_a6e00c4b
PS6, Line 42: didn't observe hang while booting
observe system boots (no hang)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62323
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e6832fb03fcc59d33df0ba1664019727185d10a
Gerrit-Change-Number: 62323
Gerrit-PatchSet: 6
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: harsha.b.r@intel.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: harsha.b.r@intel.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Comment-Date: Tue, 19 Apr 2022 09:57:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment