Roja Rani Yarubandi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35499 )
Change subject: sc7180: Add QUPv3 FW load & config
......................................................................
Patch Set 44:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35499/44/src/soc/qualcomm/sc7180/qu...
File src/soc/qualcomm/sc7180/qupv3_config.c:
https://review.coreboot.org/c/coreboot/+/35499/44/src/soc/qualcomm/sc7180/qu...
PS44, Line 21: unsigned int mode)
Why did the mode get added back here? Please explain what you're changing. […]
We added "mode" param back to be generic and portable in future.
In future if other modes also supported, then it facilitates the application to change mode param alone from mainboard file.
https://review.coreboot.org/c/coreboot/+/35499/44/src/soc/qualcomm/sc7180/qu...
PS44, Line 30: const char *filename[] = {
I think you should follow this advice, it leads to slightly better code generation.
will make it static const
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35499
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d91dd10488931247f81a87b0bdcc598f4bceb31
Gerrit-Change-Number: 35499
Gerrit-PatchSet: 44
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Doug Anderson
dianders@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Akash Asthana
akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Roja Rani Yarubandi
c_rojay@qualcomm.corp-partner.google.com
Gerrit-CC: Satya Priya Kakitapalli
c_skakit@qualcomm.corp-partner.google.com
Gerrit-CC: Stephen Boyd
swboyd@chromium.org
Gerrit-CC: Taniya Das
tdas@codeaurora.org
Gerrit-Comment-Date: Mon, 30 Mar 2020 13:18:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment