[S] Change in coreboot[main]: mb/google/brya/uldrenite: Add WWAN RW350R-GL power on sequence

[John Su (Code Review)]

Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.

John Su has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/85537?usp=email )

Change subject: mb/google/brya/uldrenite: Add WWAN RW350R-GL power on sequence
......................................................................

Patch Set 4:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85537/comment/db1c2590_a3723215?usp... :
PS3, Line 9: support
> support*s*

Done

https://review.coreboot.org/c/coreboot/+/85537/comment/fdc07746_821b8daf?usp... :
PS3, Line 11:
> Please document the source for the sequence.

b/381393809#comment1 Rolling Wireless_RW350R-GL_Hardware Guide_Generic_V1.1.pdf

https://review.coreboot.org/c/coreboot/+/85537/comment/1c5cda50_de19a0fa?usp... :
PS3, Line 14: TEST=emerge-nissa coreboot
> Is the boot time affected? Please mention the total time before and after.

The boot time is estimated to increase by 50ms. At this stage, there are no devices or motherboards available for testing. An issue, b/383212261, has been created for tracking.

File src/mainboard/google/brya/variants/uldrenite/variant.c:

https://review.coreboot.org/c/coreboot/+/85537/comment/039b0aac_d065d712?usp... :
PS3, Line 27: * RW350R power on seuqence:
            : 	* De-assert WWAN_EN -> 20ms -> de-assert WWAN_RST -> 30ms ->
            : 	* de-assert WWAN_PERST
            : 	*/
> The asterisks need to be aligned with the very first one.

Done