Change in coreboot[master]: soc/intel/block/cpu: Add function configure the CPU DEBUG interface - coreboot-gerrit

18 Jan 2021


      Attention is currently required from: Martin Roth, Arthur Heymans, Patrick Rudolph.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49673 )
Change subject: soc/intel/block/cpu: Add function configure the CPU DEBUG interface
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/49673/comment/bb62cee4_cbe902be 
PS2, Line 88: #define IA32_DEBUG_INTERFACE		0xc80
It would be good to define bits here, so that there is no need to hard code in cpu_debug.c .
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49673
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3260ba1dbe0511c7ec1dfa7e1ad241f82984e986
Gerrit-Change-Number: 49673
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Tue, 19 Jan 2021 03:14:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment