Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43493 )
Change subject: mb/amd/mandolin: add SATA DXIO descriptor for Dali SKUs ......................................................................
mb/amd/mandolin: add SATA DXIO descriptor for Dali SKUs
Dali supports two SATA ports, but no PCIe alternate function on those pins.
Change-Id: I27a13100e80565eb1dade2d703ba3d1f8b5f630f Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/43493/1
diff --git a/src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c b/src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c index 87cb6b6..326bcaa 100644 --- a/src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c +++ b/src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c @@ -146,6 +146,14 @@ .link_aspm_L1_2 = true, .turn_off_unused_lanes = true, .clk_req = CLK_REQ1 + }, + { /* SATA */ + .port_present = true, + .engine_type = SATA_ENGINE, + .start_lane = 2, + .end_lane = 3, + .gpio_group_id = 1, + .channel_type = SATA_CHANNEL_LONG, } };
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43493 )
Change subject: mb/amd/mandolin: add SATA DXIO descriptor for Dali SKUs ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43493 )
Change subject: mb/amd/mandolin: add SATA DXIO descriptor for Dali SKUs ......................................................................
mb/amd/mandolin: add SATA DXIO descriptor for Dali SKUs
Dali supports two SATA ports, but no PCIe alternate function on those pins.
Change-Id: I27a13100e80565eb1dade2d703ba3d1f8b5f630f Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/43493 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c 1 file changed, 8 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c b/src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c index 87cb6b6..326bcaa 100644 --- a/src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c +++ b/src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c @@ -146,6 +146,14 @@ .link_aspm_L1_2 = true, .turn_off_unused_lanes = true, .clk_req = CLK_REQ1 + }, + { /* SATA */ + .port_present = true, + .engine_type = SATA_ENGINE, + .start_lane = 2, + .end_lane = 3, + .gpio_group_id = 1, + .channel_type = SATA_CHANNEL_LONG, } };
-
Angel Pons (Code Review) -
Felix Held (Code Review)