Attention is currently required from: David Wu, Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj.
Eric Lai has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/84339?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa/var/riven: enable WIFI SAR
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/riven/variant.c:
https://review.coreboot.org/c/coreboot/+/84339/comment/12b2aff2_40d9c273?usp... :
PS3, Line 10: if (fw_config_probe(FW_CONFIG(WIFI_TYPE, WIFI_CNVI)) &&
Suggest use fw_config_get_field to get the value and combine the value. Code should like this:
uint64_t type = fw_config_get_field(WIFI_TYPE)
uint64_t sar_id = fw_config_get_field(WIFI_SAR_ID)
static char filename[20];
snprintf(filename, sizeof(filename), "wifi_sar_%lld.hex", type << 3 | sar_id);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84339?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I647d64a008991a7a20791b2c87ea6308af6bb82e
Gerrit-Change-Number: 84339
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 13 Sep 2024 02:26:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No