Attention is currently required from: Kane Chen, Tim Wawrzynczak.
Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62919 )
Change subject: soc/intel/{adl,common}: Add ASPM setting in pcie_rp_config.
......................................................................
Patch Set 13:
(3 comments)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/62919/comment/a0f405a6_a90123a3
PS11, Line 300: static unsigned int get_aspm_control(enum ASPM_control ctl)
nit: can you add a comment similar to the one above get_l1_substate_control() […]
Updated in latest patch.
File src/soc/intel/common/block/include/intelblocks/pcie_rp.h:
https://review.coreboot.org/c/coreboot/+/62919/comment/9ea09bf9_ee28f025
PS11, Line 63: ntrol PcieRpL1Substates;
:
`/* PCIe RP ASPM */`
Updated in latest patch.
https://review.coreboot.org/c/coreboot/+/62919/comment/b3d4bd0b_f35741b0
PS11, Line 65: PcieRpAspm
nit: […]
Updated in latest patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62919
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19b5f3dc8d95e153301d777492c921ce582ba988
Gerrit-Change-Number: 62919
Gerrit-PatchSet: 13
Gerrit-Owner: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Peichao Wang
pwang12@lenovo.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 22 Mar 2022 03:49:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment