Change in coreboot[master]: Makefile: Don't create build directory for additional targets

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Raul Rangel (Code Review)

23 Jul 2019 23 Jul '19

11:25 a.m.

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34525 )

Change subject: Makefile: Don't create build directory for additional targets ......................................................................

Makefile: Don't create build directory for additional targets

BUG=b:112267918 TEST=Ran make help and verified build directory is no longer created

Change-Id: I4bb066b5c3b3d9a7bb19291ef928042b90f10440 --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/34525/1

diff --git a/Makefile b/Makefile index dfc70e0..317a8eb 100644 --- a/Makefile +++ b/Makefile @@ -124,7 +124,7 @@ ifneq ($(filter %config %clean cross% clang iasl gnumake lint% help% what-jenkins-does,$(MAKECMDGOALS)),) NOCOMPILE:=1 endif -ifeq ($(MAKECMDGOALS), %clean) +ifneq ($(filter %clean lint% help% what-jenkins-does,$(MAKECMDGOALS)),) NOMKDIR:=1 endif endif

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Patrick Georgi (Code Review)

23 Jul 23 Jul

11:27 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34525 )

Change subject: Makefile: Don't create build directory for additional targets ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34525 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bb066b5c3b3d9a7bb19291ef928042b90f10440 Gerrit-Change-Number: 34525 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Comment-Date: Tue, 23 Jul 2019 18:27:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

24 Jul 24 Jul

4:12 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34525 )

Change subject: Makefile: Don't create build directory for additional targets ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34525/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34525/1//COMMIT_MSG@12 PS1, Line 12: Change-Id: I4bb066b5c3b3d9a7bb19291ef928042b90f10440 Your Signed-off-by line is missing.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34525 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bb066b5c3b3d9a7bb19291ef928042b90f10440 Gerrit-Change-Number: 34525 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 24 Jul 2019 11:12:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Raul Rangel (Code Review)

10:47 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34525

to look at the new patch set (#2).

Change subject: Makefile: Don't create build directory for additional targets ......................................................................

Makefile: Don't create build directory for additional targets

BUG=b:112267918 TEST=Ran make help and verified build directory is no longer created

Change-Id: I4bb066b5c3b3d9a7bb19291ef928042b90f10440 Signed-off-by: Raul E Rangel rrangel@chromium.org --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/34525/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34525 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bb066b5c3b3d9a7bb19291ef928042b90f10440 Gerrit-Change-Number: 34525 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Raul Rangel (Code Review)

11:43 a.m.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34525 )

Change subject: Makefile: Don't create build directory for additional targets ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34525/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34525/1//COMMIT_MSG@12 PS1, Line 12: Change-Id: I4bb066b5c3b3d9a7bb19291ef928042b90f10440

...

Your Signed-off-by line is missing.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/34525 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bb066b5c3b3d9a7bb19291ef928042b90f10440 Gerrit-Change-Number: 34525 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 24 Jul 2019 18:43:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Georgi (Code Review)

28 Jul 28 Jul

11:03 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34525 )

Change subject: Makefile: Don't create build directory for additional targets ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34525 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bb066b5c3b3d9a7bb19291ef928042b90f10440 Gerrit-Change-Number: 34525 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 29 Jul 2019 06:03:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

11:03 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34525 )

Change subject: Makefile: Don't create build directory for additional targets ......................................................................

Makefile: Don't create build directory for additional targets

BUG=b:112267918 TEST=Ran make help and verified build directory is no longer created

Change-Id: I4bb066b5c3b3d9a7bb19291ef928042b90f10440 Signed-off-by: Raul E Rangel rrangel@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/34525 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/34525 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bb066b5c3b3d9a7bb19291ef928042b90f10440 Gerrit-Change-Number: 34525 Gerrit-PatchSet: 3 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1937

days inactive

1943

days old

coreboot-gerrit@coreboot.org

6 comments

3 participants

tags (0)

participants (3)

Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Raul Rangel (Code Review)