Change in coreboot[master]: mb/lenovo/w541: Add Thinkpad W541 - coreboot-gerrit

9 Jun 2021


      Attention is currently required from: Peter Lemenkov, Angel Pons, Alexander Couzens, Patrick Rudolph, amersel.
Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52659 )
Change subject: mb/lenovo/w541: Add Thinkpad W541
......................................................................
Patch Set 18:
(1 comment)
File src/mainboard/lenovo/w541/mainboard.c:
https://review.coreboot.org/c/coreboot/+/52659/comment/0c4d5603_d7434a5b 
PS18, Line 8: 	install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP,
...
Since this board doesn't have eDP should this be something different? GMA_INT15_ACTIVE_LFP_INT_LVDS  […]
This file can be removed. int15 is only used when coreboot runs VGA option ROM.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52659
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08
Gerrit-Change-Number: 52659
Gerrit-PatchSet: 18
Gerrit-Owner: amersel
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Iru Cai (vimacs) mytbk920423@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Peter Lemenkov lemenkov@gmail.com
Gerrit-Attention: Peter Lemenkov lemenkov@gmail.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: amersel
Gerrit-Comment-Date: Wed, 09 Jun 2021 10:14:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Lemenkov lemenkov@gmail.com
Gerrit-MessageType: comment