Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41990 )
Change subject: mb/google/dedede/var/wheelie: Add memory parts and generate DRAM IDs ......................................................................
mb/google/dedede/var/wheelie: Add memory parts and generate DRAM IDs
This change adds memory parts used by variant wheelie to mem_list_variant.txt and generates DRAM IDs allocated to these parts.
BUG=b:157862308
Change-Id: I53f6f5c832cd40068a6d4379ace849f6e8ad7a91 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/dedede/variants/wheelie/memory/Makefile.inc M src/mainboard/google/dedede/variants/wheelie/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/wheelie/memory/mem_list_variant.txt 3 files changed, 11 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41990/1
diff --git a/src/mainboard/google/dedede/variants/wheelie/memory/Makefile.inc b/src/mainboard/google/dedede/variants/wheelie/memory/Makefile.inc index add0919..e82241f 100644 --- a/src/mainboard/google/dedede/variants/wheelie/memory/Makefile.inc +++ b/src/mainboard/google/dedede/variants/wheelie/memory/Makefile.inc @@ -3,4 +3,7 @@
MEM_TYPE = lp4x SPD_SOURCES = -SPD_SOURCES += spd-8.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:F +SPD_SOURCES += spd-8.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E +SPD_SOURCES += spd-3.hex # ID = 1(0b0001) Parts = K4U6E3S4AA-MGCR +SPD_SOURCES += spd-1.hex # ID = 2(0b0010) Parts = H9HCNNNBKMMLXR-NEE +SPD_SOURCES += spd-9.hex # ID = 3(0b0011) Parts = NT6AP256T32AV-J2 diff --git a/src/mainboard/google/dedede/variants/wheelie/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/wheelie/memory/dram_id.generated.txt index 93934ae..a856e26 100644 --- a/src/mainboard/google/dedede/variants/wheelie/memory/dram_id.generated.txt +++ b/src/mainboard/google/dedede/variants/wheelie/memory/dram_id.generated.txt @@ -1,2 +1,5 @@ DRAM Part Name ID to assign -MT53E512M32D2NP-046 WT:F 0 (0000) +MT53E512M32D2NP-046 WT:E 0 (0000) +K4U6E3S4AA-MGCR 1 (0001) +H9HCNNNBKMMLXR-NEE 2 (0010) +NT6AP256T32AV-J2 3 (0011) diff --git a/src/mainboard/google/dedede/variants/wheelie/memory/mem_list_variant.txt b/src/mainboard/google/dedede/variants/wheelie/memory/mem_list_variant.txt index 08daad4..2dc3706 100644 --- a/src/mainboard/google/dedede/variants/wheelie/memory/mem_list_variant.txt +++ b/src/mainboard/google/dedede/variants/wheelie/memory/mem_list_variant.txt @@ -1,2 +1,4 @@ -MT53E512M32D2NP-046 WT:F +MT53E512M32D2NP-046 WT:E +K4U6E3S4AA-MGCR +H9HCNNNBKMMLXR-NEE NT6AP256T32AV-J2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41990 )
Change subject: mb/google/dedede/var/wheelie: Add memory parts and generate DRAM IDs ......................................................................
Patch Set 9:
This change is ready for review.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41990 )
Change subject: mb/google/dedede/var/wheelie: Add memory parts and generate DRAM IDs ......................................................................
Patch Set 10: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41990 )
Change subject: mb/google/dedede/var/wheelie: Add memory parts and generate DRAM IDs ......................................................................
mb/google/dedede/var/wheelie: Add memory parts and generate DRAM IDs
This change adds memory parts used by variant wheelie to mem_list_variant.txt and generates DRAM IDs allocated to these parts.
BUG=b:157862308
Change-Id: I53f6f5c832cd40068a6d4379ace849f6e8ad7a91 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41990 Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/wheelie/memory/Makefile.inc M src/mainboard/google/dedede/variants/wheelie/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/wheelie/memory/mem_list_variant.txt 3 files changed, 5 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/wheelie/memory/Makefile.inc b/src/mainboard/google/dedede/variants/wheelie/memory/Makefile.inc index 573213b..2c50412 100644 --- a/src/mainboard/google/dedede/variants/wheelie/memory/Makefile.inc +++ b/src/mainboard/google/dedede/variants/wheelie/memory/Makefile.inc @@ -2,4 +2,4 @@ ## This is an auto-generated file. Do not edit!!
SPD_SOURCES = -SPD_SOURCES += spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E +SPD_SOURCES += spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, K4U6E3S4AA-MGCR, H9HCNNNBKMMLXR-NEE diff --git a/src/mainboard/google/dedede/variants/wheelie/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/wheelie/memory/dram_id.generated.txt index a825c3a..0df7bfc 100644 --- a/src/mainboard/google/dedede/variants/wheelie/memory/dram_id.generated.txt +++ b/src/mainboard/google/dedede/variants/wheelie/memory/dram_id.generated.txt @@ -1,2 +1,4 @@ DRAM Part Name ID to assign MT53E512M32D2NP-046 WT:E 0 (0000) +K4U6E3S4AA-MGCR 0 (0000) +H9HCNNNBKMMLXR-NEE 0 (0000) diff --git a/src/mainboard/google/dedede/variants/wheelie/memory/mem_list_variant.txt b/src/mainboard/google/dedede/variants/wheelie/memory/mem_list_variant.txt index 20887c1..47159f8 100644 --- a/src/mainboard/google/dedede/variants/wheelie/memory/mem_list_variant.txt +++ b/src/mainboard/google/dedede/variants/wheelie/memory/mem_list_variant.txt @@ -1 +1,3 @@ MT53E512M32D2NP-046 WT:E +K4U6E3S4AA-MGCR +H9HCNNNBKMMLXR-NEE