Attention is currently required from: Cliff Huang, Lance Zhao, Paul Menzel, Subrata Banik, Subrata Banik, Tim Wawrzynczak.
David Ruth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80170?usp=email )
Change subject: Add MTCL function to ACPI SSDT tables ......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80170/comment/8f29c4d7_ec63253f : PS5, Line 17:
Why is this ChromeOS specific, that means, you change things under `vendorcode/`?
The functionality is being added specifically for Chromebooks and ChromeOS. It is similar in many ways to the functionality in sar.c and wrdd.c in the same directory.
https://review.coreboot.org/c/coreboot/+/80170/comment/f7697be1_f90825a1 : PS5, Line 27:
Where is the format of the file defined?
I did define the format in the comment for get_wifi_mtcl in mtcl.c starting on line 9, but it is a little hand-wavy. I'd accept suggestions to make it better.
Patchset:
PS5:
Welcome to coreboot! […]
Thanks!
You'll need at least https://lore.kernel.org/all/20240116024857.9071-3-mingyen.hsieh@mediatek.com... and https://lore.kernel.org/all/20240111061856.16370-1-mingyen.hsieh@mediatek.co... on top of upstream. There were quite a few patches recently that helped implement this functionality, and I'm not sure that all of them are quite upstream yet, unfortunately.
File src/drivers/wifi/generic/Kconfig:
https://review.coreboot.org/c/coreboot/+/80170/comment/c3e20e53_61c65afd : PS5, Line 69: When enabled, adds the MTCL function for MediaTek : WiFi chipsets. This function supplies country list information : used to enable or disable operation on 5.9GHz and 6GHz : bands.
Please reflow. Then it should fit in three lines? […]
Done.
The file is just a binary file that has data in the format specified in get_wifi_mtcl. I generated test files with a small c program that just writes bytes to disk, but any way you know how to get bytes in a file with do.