Change in coreboot[master]: xeon_sp: Fix skx uncore.asl \_SB namespace issue

[Marc Jones (Code Review)]

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45269 )

Change subject: xeon_sp: Fix skx uncore.asl _SB namespace issue
......................................................................

xeon_sp: Fix skx uncore.asl _SB namespace issue

The skx uncore acpi scope was missing the \ on _SB causing
the uncore IRQs to not be in the namespace. This addresses
ACPI uncore IRQ routing issues. This was found preparing
skx acpi to match cpx acpi for merging in the future.

Change-Id: I799042babbe60287e5e4ec60b21c08d57ccda04b
Signed-off-by: Marc Jones 
---
M src/soc/intel/xeon_sp/skx/acpi/uncore.asl
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/45269/1

diff --git a/src/soc/intel/xeon_sp/skx/acpi/uncore.asl b/src/soc/intel/xeon_sp/skx/acpi/uncore.asl
index 498a997..c6c6576 100644
--- a/src/soc/intel/xeon_sp/skx/acpi/uncore.asl
+++ b/src/soc/intel/xeon_sp/skx/acpi/uncore.asl
@@ -25,7 +25,7 @@
    }
 }

-Scope (_SB)
+Scope (_SB)
 {
    #include "pci_irq.asl"
    #include "uncore_irq.asl"

[Jay Talbott (Code Review)]

Jay Talbott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45269 )

Change subject: xeon_sp: Fix skx uncore.asl _SB namespace issue
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45269 )

Change subject: xeon_sp: Fix skx uncore.asl _SB namespace issue
......................................................................

Patch Set 1: Code-Review+2

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45269 )

Change subject: xeon_sp: Fix skx uncore.asl _SB namespace issue
......................................................................

Patch Set 1: Code-Review+2

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45269 )

Change subject: xeon_sp: Fix skx uncore.asl _SB namespace issue
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45269/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45269/1//COMMIT_MSG@7 
PS1, Line 7: xeon_sp: Fix skx uncore.asl _SB namespace issue
For the title, we have been using this format for the code area: soc/intel/xeon_sp/skx

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/45269 )

Change subject: xeon_sp: Fix skx uncore.asl _SB namespace issue
......................................................................

Removed Code-Review+2 by HAOUAS Elyes

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45269 )

Change subject: xeon_sp: Fix skx uncore.asl _SB namespace issue
......................................................................

Patch Set 1:

I think it is ASL 2.0 syntax.

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45269 )

Change subject: xeon_sp: Fix skx uncore.asl _SB namespace issue
......................................................................

Patch Set 1:

(1 comment)
> Patch Set 1:
>
> I think it is ASL 2.0 syntax.

I think the syntax has always been _ and this was a typo/general bug.

https://review.coreboot.org/c/coreboot/+/45269/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45269/1//COMMIT_MSG@7 
PS1, Line 7: xeon_sp: Fix skx uncore.asl _SB namespace issue
> For the title, we have been using this format for the code area: soc/intel/xeon_sp/skx

Ack

Change in coreboot[master]: soc/intel/xeon_sp/skx: Fix uncore.asl \_SB namespace issue

[Marc Jones (Code Review)]

Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Jonathan Zhang, Jay Talbott, Johnny Lin, Angel Pons, Morgan Jang, Patrick Rudolph, HAOUAS Elyes,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45269

to look at the new patch set (#2).

Change subject: soc/intel/xeon_sp/skx: Fix uncore.asl _SB namespace issue
......................................................................

soc/intel/xeon_sp/skx: Fix uncore.asl _SB namespace issue

The skx uncore ACPI scope was missing the \ on _SB causing
the uncore IRQs to not be in the namespace. This addresses
ACPI uncore IRQ routing issues. This was found preparing
skx acpi to match cpx acpi for merging in the future.

Check scope in dsdt.asl in tiogapass build.

Change-Id: I799042babbe60287e5e4ec60b21c08d57ccda04b
Signed-off-by: Marc Jones 
---
M src/soc/intel/xeon_sp/skx/acpi/uncore.asl
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/45269/2

Change in coreboot[master]: soc/intel/xeon_sp/skx: Fix uncore.asl \_SB namespace issue

[Jay Talbott (Code Review)]

Jay Talbott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45269 )

Change subject: soc/intel/xeon_sp/skx: Fix uncore.asl _SB namespace issue
......................................................................

Patch Set 2: Code-Review+1

Change in coreboot[master]: soc/intel/xeon_sp/skx: Fix uncore.asl \_SB namespace issue

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45269 )

Change subject: soc/intel/xeon_sp/skx: Fix uncore.asl _SB namespace issue
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: soc/intel/xeon_sp/skx: Fix uncore.asl \_SB namespace issue

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45269 )

Change subject: soc/intel/xeon_sp/skx: Fix uncore.asl _SB namespace issue
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: soc/intel/xeon_sp/skx: Fix uncore.asl \_SB namespace issue

[Maxim Polyakov (Code Review)]

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45269 )

Change subject: soc/intel/xeon_sp/skx: Fix uncore.asl _SB namespace issue
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: soc/intel/xeon_sp/skx: Fix uncore.asl \_SB namespace issue

[Marc Jones (Code Review)]

Marc Jones has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45269 )

Change subject: soc/intel/xeon_sp/skx: Fix uncore.asl _SB namespace issue
......................................................................

soc/intel/xeon_sp/skx: Fix uncore.asl _SB namespace issue

The skx uncore ACPI scope was missing the \ on _SB causing
the uncore IRQs to not be in the namespace. This addresses
ACPI uncore IRQ routing issues. This was found preparing
skx acpi to match cpx acpi for merging in the future.

Check scope in dsdt.asl in tiogapass build.

Change-Id: I799042babbe60287e5e4ec60b21c08d57ccda04b
Signed-off-by: Marc Jones 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45269
Reviewed-by: HAOUAS Elyes 
Reviewed-by: Angel Pons 
Reviewed-by: Maxim Polyakov 
Reviewed-by: Jay Talbott 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/xeon_sp/skx/acpi/uncore.asl
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  HAOUAS Elyes: Looks good to me, approved
  Angel Pons: Looks good to me, approved
  Jay Talbott: Looks good to me, but someone else must approve
  Maxim Polyakov: Looks good to me, approved

diff --git a/src/soc/intel/xeon_sp/skx/acpi/uncore.asl b/src/soc/intel/xeon_sp/skx/acpi/uncore.asl
index 498a997..c6c6576 100644
--- a/src/soc/intel/xeon_sp/skx/acpi/uncore.asl
+++ b/src/soc/intel/xeon_sp/skx/acpi/uncore.asl
@@ -25,7 +25,7 @@
    }
 }

-Scope (_SB)
+Scope (_SB)
 {
    #include "pci_irq.asl"
    #include "uncore_irq.asl"