Nitheesh Sekar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29967 )
Change subject: qclib: Add qclib support with interface tables ......................................................................
Patch Set 36:
(3 comments)
https://review.coreboot.org/c/coreboot/+/29967/30/src/mainboard/google/mistr... File src/mainboard/google/mistral/romstage.c:
https://review.coreboot.org/c/coreboot/+/29967/30/src/mainboard/google/mistr... PS30, Line 32: qclib_load_and_run();
Does QCLIB need to enable USB-related clocks? Ideally it shouldn't -- USB should be fully controlled […]
Hi Julius, Like you said we have fixed this in Qclib and made the qclib_load_run as the last call.
https://review.coreboot.org/c/coreboot/+/29967/35/src/mainboard/google/mistr... File src/mainboard/google/mistral/romstage.c:
https://review.coreboot.org/c/coreboot/+/29967/35/src/mainboard/google/mistr... PS35, Line 20: __weak void qclib_set_buck_type(void) {} Cleaned up to remove buck_type support code.
https://review.coreboot.org/c/coreboot/+/29967/33/src/soc/qualcomm/common/qc... File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/29967/33/src/soc/qualcomm/common/qc... PS33, Line 18: #include <string.h>
duplicate (see line 20)
Done
-
Nitheesh Sekar (Code Review)