Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel, Angel Pons, Jianjun Wang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63019 )
Change subject: soc/mediatek: Add mtk_early_init for passing data across sessions
......................................................................
Patch Set 1:
(2 comments)
File src/soc/mediatek/common/include/soc/early_init.h:
https://review.coreboot.org/c/coreboot/+/63019/comment/5a959006_e16cc4b0
PS1, Line 10: mtk_early_init
I'd prefer "early_init_data".
Ack
https://review.coreboot.org/c/coreboot/+/63019/comment/d4125f31_9fa2e3e1
PS1, Line 10: mtk_early_init
I'd prefer "early_init_data".
Or, to avoid confusion, how about "persistent_data" (to reflect the purpose) or "early_data" (to make it more general for future usage) or "sram_data"? Hung-Te, any suggestion?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63019
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I01f91b7fe2cbe4f73b5c616bb7aae778dee27d9a
Gerrit-Change-Number: 63019
Gerrit-PatchSet: 1
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 24 Mar 2022 02:49:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment