Attention is currently required from: Dinesh Gehlot, Elyes Haouas, Nico Huber, Paul Menzel, Thomas Heijligen.
Angel Pons has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/libgfxinit/+/81522?usp=email )
Change subject: gma display_probing: Make new TGL ports available
......................................................................
Patch Set 7:
(1 comment)
File common/hw-gfx-gma-display_probing.adb:
https://review.coreboot.org/c/libgfxinit/+/81522/comment/c18c45c1_fcc89d7e?u... :
PS7, Line 38: function Sibling_Port (Port : Port_Type) return Port_Type is
Yes, but DPx and HDMIx refer to the traditional (not Type-C capable) ports. I think this is fine.
Hmmmmm, wait. HDMI_TCx and USBCx would need to be here, I think?
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/81522?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I9d96673f931be0086536044694ecd127ba2a823d
Gerrit-Change-Number: 81522
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Dinesh Gehlot
digehlot@google.com
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 29 Aug 2024 15:34:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com