Attention is currently required from: Felix Singer, Martin Roth, Matt DeVillier, Tim Wawrzynczak.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62796 )
Change subject: x86/smbios_defaults: Set default system manufacturer for ChromeOS devices
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/arch/x86/smbios_defaults.c:
https://review.coreboot.org/c/coreboot/+/62796/comment/3e2e5919_a6c23cbd
PS1, Line 121: return smbios_mainboard_manufacturer();
I'm unclear what exactly you're looking for here
When no log message is needed, I meant:
return CONFIG(MAINBOARD_HAS_CHROMEOS) ? "Google" : smbios_mainboard_manufacturer();
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62796
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9de17fa12689ab4e627b995818aa3d2653102b04
Gerrit-Change-Number: 62796
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 15 Mar 2022 15:04:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment