Attention is currently required from: Tarun Tuli, Subrata Banik, Eric Lai.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74380 )
Change subject: soc/intel/meteoerlake: set power limits dynamically ......................................................................
Patch Set 3:
(4 comments)
File src/soc/intel/meteorlake/chip.h:
https://review.coreboot.org/c/coreboot/+/74380/comment/365742fe_fb3209f2 PS2, Line 33: static const struct
As of now it's only for systemagent.c file. […]
I would prefer to keep in this chip header file only because in future this list will grow with respect to different SKUs and TDPs. Please, refer alderlake/chip.h for an example.
File src/soc/intel/meteorlake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/74380/comment/eb207e2d_4d1b4bae PS3, Line 147: configure_tdp
do we expect someone will call this function outside soc_systemagent_init() ? if no, then please mak […]
Done
https://review.coreboot.org/c/coreboot/+/74380/comment/6ef0a5b2_6595d5f1 PS3, Line 170: /* Choose power limits configuration based on the CPU SA PCI ID and : * CPU TDP value. */
can u please use […]
Sure. Thanks.
https://review.coreboot.org/c/coreboot/+/74380/comment/49dd2f1a_a6e7bc47 PS3, Line 194: Ramstage
ramstage?
Done
-
Sumeet R Pawnikar (Code Review)