Attention is currently required from: Elyes Haouas, Felix Singer, Jérémy Compostella, Vasiliy Khoruzhick, yuchi.chen@intel.com.
Shuo Liu has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83321?usp=email )
Change subject: soc/intel/snowridge: Add support for Intel Atom Snow Ridge SoC ......................................................................
Patch Set 21:
(5 comments)
File src/soc/intel/snowridge/acpi/ith.asl:
https://review.coreboot.org/c/coreboot/+/83321/comment/4dc282c7_113e665e?usp... : PS17, Line 2:
It's referred by the last line of southcluster.asl.
Done
File src/soc/intel/snowridge/romstage/gpio_snr.c:
https://review.coreboot.org/c/coreboot/+/83321/comment/fa21c1a5_14c26ac0?usp... : PS15, Line 160: */
yes.
Done
File src/soc/intel/snowridge/systemagent.c:
https://review.coreboot.org/c/coreboot/+/83321/comment/05eb0768_734c81b3?usp... : PS15, Line 33: {
This pointer is passed from common system agent code, representing current assigned resources in sys […]
Done
File src/soc/intel/snowridge/systemagent.c:
https://review.coreboot.org/c/coreboot/+/83321/comment/10ea0bc1_abbcf10d?usp... : PS21, Line 53: { here we need to rename resource_cnt to resource_index as well.
https://review.coreboot.org/c/coreboot/+/83321/comment/63fd9a7c_0ef982ea?usp... : PS21, Line 77: &snr_configurable_resources[i].resources, 1); here, can we omit the parameter '1'? a.k.a. for all cases, only one resource is added once.