[S] Change in coreboot[main]: mb/google/corsola: Make compatible with MT8186T by modifing skuid - coreboot-gerrit

13 Sep 2024


      Attention is currently required from: Hung-Te Lin, Knox Chiou, Yang Wu, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )
Change subject: mb/google/corsola: Make compatible with MT8186T by modifing skuid
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/84342/comment/8e418b03_6923fcc8?usp... :
PS2, Line 132: BOARD_GOOGLE_STEELIX
...
On our projects `Voltrob` and `Squirtle`, we have already used 0x7fffffff as the the default SKU ID  […]
Why does Steelix needs a different SKU ID (different DTS), but Voltrob/Squirtle doesn't?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84342?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Gerrit-Change-Number: 84342
Gerrit-PatchSet: 2
Gerrit-Owner: Yang Wu wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Knox Chiou knoxchiou@google.com
Gerrit-Reviewer: Xinxiong Xu xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Knox Chiou knoxchiou@google.com
Gerrit-Attention: Yang Wu wuyang5@huaqin.corp-partner.google.com
Gerrit-Attention: Yidi Lin yidilin@google.com
Gerrit-Comment-Date: Fri, 13 Sep 2024 09:51:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yang Wu wuyang5@huaqin.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com