Change in coreboot[master]: Kconfig: Hide stage cache selection on !HAVE_ACPI_RESUME - coreboot-gerrit

25 Apr 2022


      Attention is currently required from: Arthur Heymans.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63677 )
Change subject: Kconfig: Hide stage cache selection on !HAVE_ACPI_RESUME
......................................................................
Patch Set 1:
(1 comment)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/63677/comment/121b8e5c_9a774cda 
PS1, Line 331: 	depends on HAVE_ACPI_RESUME
With this HAVE_ACPI_RESUME=n implies NO_STAGE_CACHE=n, and resume_from_stage_cache() will actually call romstage_handoff_is_resume().
Not a big deal, maybe you want to add !CONFIG(HAVE_ACPI_RESUME) there?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63677
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I005ebde53d99b946dc54644e17b07ca12b32c0a6
Gerrit-Change-Number: 63677
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 24 Apr 2022 22:58:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment